Ensure variables are kept when refetching with a suspense hook that uses skipToken

[jerelmiller]

Fixes #12989

Alternative to #12992.

The core issue with the current implementation is that the cacheKey created when using skipToken is different since skipToken doesn't include variables. This meant switching from options with variables to skipToken would create a new ObservableQuery via client.watchQuery. This also meant you'd have 2 active ObservableQuery instances. In the reproduction from #12989, this was confirmed where you see 2 fetches when the mutation's refetchQueries was run.

This PR fixes the issue by keeping the last used variables in state so that the cache key remains the same when switching to skipToken. This maintains the existing ObservableQuery instance and puts it in standby mode.

[changeset-bot]

🦋 Changeset detected

Latest commit: 17abb5c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[apollo-librarian]

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: f11b00fc2d73ddc70aae49c8
Build Logs: View logs

[pkg-pr-new]

npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client@12993

commit: 17abb5c

[jerelmiller]

This PR should fix the need for this: testing-library/react-render-stream-testing-library#15

[phryneas]

This has been released :)

[jerelmiller]

I updated the failing tests as a result of this change over to the render stream helpers for assertion. With the update to useSuspenseQuery which calls setState in render, the raw render count went up with each of these tests which caused the failure. Rather than increasing the count, I switched over to the render stream library to more accurately represent the committed renders.