Skip to content

[YUNIKORN-2249] Add compression option to API's response#1090

Closed
OSingh wants to merge 3 commits into
apache:masterfrom
OSingh:YUNIKORN-2249
Closed

[YUNIKORN-2249] Add compression option to API's response#1090
OSingh wants to merge 3 commits into
apache:masterfrom
OSingh:YUNIKORN-2249

Conversation

@OSingh

@OSingh OSingh commented Jun 3, 2026 •
edited by wilfred-s
Loading

Copy link
Copy Markdown
Contributor

What is this PR for?

A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - http://yunikorn.apache.org/community/how_to_contribute

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

YUNIKORN-2249

How should this be tested?

deployed on k8s cluster

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

wilfred-s
wilfred-s requested changes Jun 4, 2026
View reviewed changes
Comment thread pkg/webservice/gzip.go Outdated
@wilfred-s wilfred-s changed the title Add compression option to API's response [YUNIKORN-2249] Add compression option to API's response Jun 9, 2026
@wilfred-s

wilfred-s commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@OSingh we need a pass of make lint before we can commit this. Please check

wilfred-s
wilfred-s requested changes Jun 9, 2026
View reviewed changes
Comment thread pkg/webservice/gzip.go Outdated
Comment thread pkg/webservice/gzip.go Outdated
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.06250% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.40%. Comparing base (fad16fd) to head (5cfe94c).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/webservice/gzip.go 63.49% 16 Missing and 7 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
- Coverage   81.47%   81.40%   -0.07%     
==========================================
  Files         103      104       +1     
  Lines       13963    14037      +74     
==========================================
+ Hits        11376    11427      +51     
- Misses       2310     2327      +17     
- Partials      277      283       +6

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wilfred-s
wilfred-s approved these changes Jun 10, 2026
View reviewed changes

@wilfred-s wilfred-s left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wilfred-s wilfred-s closed this in 77b42be Jun 10, 2026
wilfred-s pushed a commit that referenced this pull request Jun 10, 2026
@OSingh @wilfred-s
[YUNIKORN-2249] Add compression to REST API (#1090)
922bc77 
Add compression to REST API and compress output when larger than a
single frame. Based on MTU of 1500, compress data when it exceeds 1400
bytes.

Closes: #1090

Signed-off-by: Wilfred Spiegelenburg <wilfreds@apache.org>
(cherry picked from commit 77b42be)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wilfred-s wilfred-s wilfred-s approved these changes

Assignees

@OSingh OSingh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OSingh @wilfred-s