Drop dsa_bits reference; rpgp-py 0.19.7 doesn't expose it#1232
Closed
andrewmusselman wants to merge 1 commit into
Closed
Drop dsa_bits reference; rpgp-py 0.19.7 doesn't expose it#1232andrewmusselman wants to merge 1 commit into
andrewmusselman wants to merge 1 commit into
Conversation
`make check` fails pyright on main with reportAttributeAccessIssue for PublicParamsInfo.dsa_bits, added in 9cc1dbb (Restore support for DSA keys). rpgp-py 0.19.7 has no dsa_bits attribute and no equivalent field; for a DSA key, all numeric fields on PublicParamsInfo return None, only kind == dsa identifies it. DSA keys now raise a clear ValueError instead of AttributeError. RSA and ECC unaffected. Restoring DSA bit-length validation needs upstream work in rpgp-py.
Contributor
No, it does: @property
def dsa_bits(self) -> Optional[int]: ...I know this because I added it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make checkfails pyright on main with reportAttributeAccessIssue for PublicParamsInfo.dsa_bits, added in 9cc1dbb (Restore support for DSA keys). rpgp-py 0.19.7 has no dsa_bits attribute and no equivalent field; for a DSA key, all numeric fields on PublicParamsInfo return None, only kind == dsa identifies it.DSA keys now raise a clear ValueError instead of AttributeError. RSA and ECC unaffected. Restoring DSA bit-length validation needs upstream work in rpgp-py.
Testing
make checkpassesRebase info