-
Notifications
You must be signed in to change notification settings - Fork 53
Lazy Raster Loading Support for Zarr and GDAL #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
james-willis
wants to merge
19
commits into
apache:main
Choose a base branch
from
james-willis:jw/outdb-loader-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,698
−36
Open
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6423550
feat(sedona-raster): AsyncByteLoader trait + OutDbLoaderRegistry
james-willis a75126e
feat(sedona-expr): needs_bytes annotation on SedonaScalarUDF
james-willis ae65d5f
feat(sedona): RS_EnsureLoaded async UDF + register_outdb_loader API
james-willis b4c7338
feat(sedona): analyzer rule wraps needs_bytes UDFs with RS_EnsureLoaded
james-willis 3f0b27c
feat(sedona-raster-gdal): GdalLoader implementing AsyncByteLoader
james-willis d7fce30
feat(sedona-raster-zarr): ZarrLoader implementing AsyncByteLoader
james-willis 57e910d
chore: review revisions
james-willis d616992
feat(sedona-raster-gdal): block-aligned cancellable loop + byte cap
james-willis 05fb09f
refactor(raster): host OutDb loader registry on ConfigOptions
james-willis 4ec95e9
fix(raster): preserve raster extension in RS_EnsureLoaded output + De…
james-willis da6b533
refactor(raster): move RS_EnsureLoaded wrapping to a logical optimize…
james-willis 486864b
refactor(raster): move RsEnsureLoaded to sedona-raster-functions; gen…
james-willis b856b49
docs(raster): link issue #897 from the view round-trip gap sites
james-willis b2de837
refactor(raster): derive Debug for OutDbLoaderRegistry
james-willis 05a247d
fix(sedona-query-planner): commit the ensure_loaded.rs that the modul…
james-willis 9abb8d5
revert(c/sedona-extension): drop the SedonaCScalarKernel metadata FFI…
james-willis 9bdf464
Merge remote-tracking branch 'origin/main' into jw/outdb-loader-v2
james-willis 9a2d1f1
refactor(raster): use sedona_internal_err!/plan_err! instead of Err(.…
james-willis 7fdebc4
refactor(raster): trim RS_EnsureLoaded boilerplate; set ideal async b…
james-willis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love having raster function (or any geo-specific) stuff live here.
with_needs_bytesis sufficiently compact that you can probably just inline it to the functions that need it. The named constant can probably live in sedona-raster-functions and you can duplicate it if that creates weird cross-crate interactions?