Conversation
This re-renders modified Doxia sources automatically. Deprecate "run" goal in favour of this one. This closes #1266
|
Will check next week. |
There was a problem hiding this comment.
What about reports? In 3.20.x I have made it possible to re-render reports, even external ones. Is it still the case here? Is the improvement not to have Jetty anymore? The asciidoctor plugin has a very similar feature, worth looking at and it never worked reliably for me.
michael-o
left a comment
There was a problem hiding this comment.
So I went through the code and done some tests. The behavior is different compared to site:run. I would like to align this feature with https://docs.asciidoctor.org/maven-tools/latest/plugin/goals/auto-refresh/ calling it site:auto-refresh just consistency. I don't see how this fully replaces ´site:run, complement yes, replacement no. Moreover, site:run` gives you very detailed information on stuff it renders which is very helpful.
What do you miss exactly?
What information is that exactly and isn't this also logged with this goal?
I am fine with that.
Long term yes, having a Java Servlet Container just to serve static files is way to much overhead. Compare with #1240 and feel free to comment there. There were valid complaints from user's that m-site-p is too heavyweight in terms of dependencies and I agree with that. |
Agree too, using Jetty or any servlet container for static is a bit overengineering (and I'm a Jetty committer :)) or simply use |
This one generates everything, given a large site with quite some reports will need time, the :run does on request.
Please run it yourself, you will see all info: source, report, locale, very helpful.
I agree that having the weight of a Servlet Container is bad, in fact we touched this topic with @hboutemy years ago and wanted to move it out to a |
This re-renders modified Doxia sources automatically. Deprecate "run" goal in favour of this one.
This closes #1266
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.