Skip to content

fix(github_graphql): keep requestedIssues out of GraphQL query in Collect Issues#8855

Merged
klesh merged 1 commit intoapache:mainfrom
yamoyamoto:fix/8853-graphql-issue-detail-wrapper-leak
Apr 27, 2026
Merged

fix(github_graphql): keep requestedIssues out of GraphQL query in Collect Issues#8855
klesh merged 1 commit intoapache:mainfrom
yamoyamoto:fix/8853-graphql-issue-detail-wrapper-leak

Conversation

@yamoyamoto
Copy link
Copy Markdown
Contributor

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

Putting the per-batch metadata on the wrapper struct caused merico-ai/graphql to emit it as a top-level GraphQL field. Moved it off the wrapper into a sync.Map kept in the surrounding closure.

Does this close any open issues?

Closes #8853

Screenshots

N/A

Other Information

…lect Issues

Signed-off-by: yamoyamoto <yamo7yamoto@gmail.com>
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. pr-type/bug-fix This PR fixes a bug labels Apr 26, 2026
Copy link
Copy Markdown
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@klesh klesh merged commit 49959f6 into apache:main Apr 27, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-type/bug-fix This PR fixes a bug size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][github_graphql] Collect Issues fails on second phase with Field 'requestedIssues' doesn't exist on type 'Query'

2 participants