fix(catalog/s3tables): stop dropping endpoint_url for empty properties#2623
Open
Kurtiscwright wants to merge 1 commit into
Open
fix(catalog/s3tables): stop dropping endpoint_url for empty properties#2623Kurtiscwright wants to merge 1 commit into
Kurtiscwright wants to merge 1 commit into
Conversation
This PR removes the `properties.is_empty()` check from the s3tables `create_sdk_config`. This check was causing an empty properties to be return even when an endpoint_url was provided because the endpoint wasn't passed into properties before this check ran. Dropping the check seemed like the best approach because it only saved three (credentials, profile, region, and endpoint) checks at Catalog start up. If performance testing shows this skip is needed in the future than it can be added back in. Added new unit test to prevent any regressions on future PRs.
CTTY
reviewed
Jun 12, 2026
| if properties.is_empty() { | ||
| return config.load().await; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Should we just move this block to after the endpoint_url check?
Contributor
Author
There was a problem hiding this comment.
I considered that approach, but I chose the current implementation for two reasons:
- It read like a premature optimization to me to have this check. This validation is only ran at Catalog load time so once per session and the number of checks are only 4 at the moment.
- Keeping this check leaves this same class of bug for any future property flag implementations.
For both of the above reasons. I felt it was better to remove the check altogether rather than shuffle it further down. I can add it back in if there is strong disagreement with my two reasons listed above.
dannycjones
approved these changes
Jun 12, 2026
dannycjones
left a comment
dannycjones
left a comment
Contributor
There was a problem hiding this comment.
I don't have a strong opinion on moving or dropping the is_empty check, thanks for the fix and test!
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This PR removes the
properties.is_empty()check from the s3tablescreate_sdk_config. This check was causing an empty properties to be return even when an endpoint_url was provided because the endpoint wasn't passed into properties before this check ran.Dropping the check seemed like the best approach because it only saved three (credentials, profile, region, and endpoint) checks at Catalog start up. If performance testing shows this skip is needed in the future than it can be added back in.
Are these changes tested?
Added new unit test to prevent any regressions on future PRs.