Skip to content

Xuliang0317 patch 1 #8287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xuliang0317 wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −16
Open

Xuliang0317 patch 1 #8287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d65038
Refactor BloomFilterUtil by removing bitvals array
xuliang0317 May 30, 2026
52805ba
Update BloomFilterChunk.java
xuliang0317 May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/util/BloomFilterChunk.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,26 +203,24 @@ private void setHashLoc(int hash1, int hash2) {
* @param pos index of bit
*/
void set(long pos) {
int bytePos = (int) (pos / 8);
int bitPos = (int) (pos % 8);
int bytePos = (int) (pos >> 3);
int bitPos = (int) (pos & 7);
byte curByte = bloom.get(bytePos);
curByte |= BloomFilterUtil.bitvals[bitPos];
curByte |= (1 << bitPos);
bloom.put(bytePos, curByte);
}
}

/**
* Check if bit at specified index is 1.
* @param pos index of bit
* @return true if bit at specified index is 1, false if 0.
*/
static boolean get(int pos, ByteBuffer bloomBuf, int bloomOffset) {
int bytePos = pos >> 3; // pos / 8
int bitPos = pos & 0x7; // pos % 8
// TODO access this via Util API which can do Unsafe access if possible(?)
int bytePos = pos >> 3;
int bitPos = pos & 0x7;
byte curByte = bloomBuf.get(bloomOffset + bytePos);
curByte &= BloomFilterUtil.bitvals[bitPos];
return (curByte != 0);
}
return (curByte & (1 << bitPos)) != 0;
}

@Override
public long getKeyCount() {
Expand Down
7 changes: 1 addition & 6 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/util/BloomFilterUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ public final class BloomFilterUtil {

public static final String PREFIX_LENGTH_KEY = "RowPrefixBloomFilter.prefix_length";

/** Bit-value lookup array to prevent doing the same work over and over */
public static final byte[] bitvals = { (byte) 0x01, (byte) 0x02, (byte) 0x04, (byte) 0x08,
(byte) 0x10, (byte) 0x20, (byte) 0x40, (byte) 0x80 };

/**
* Private constructor to keep this class from being instantiated.
*/
Expand Down Expand Up @@ -221,8 +217,7 @@ static boolean checkBit(int pos, ByteBuff bloomBuf, int bloomOffset) {
int bytePos = pos >> 3; // pos / 8
int bitPos = pos & 0x7; // pos % 8
byte curByte = bloomBuf.get(bloomOffset + bytePos);
curByte &= bitvals[bitPos];
return (curByte != 0);
return (curByte & (1 << bitPos)) != 0;
}

/**
Expand Down