feat: Add From<Option<T>> trait for Precision enum - #22792
Merged
Conversation
devanbenz
marked this pull request as ready for review
June 8, 2026 15:56
kosiew
reviewed
Jun 9, 2026
Contributor
There was a problem hiding this comment.
@devanbenz
Thanks for your contribution. I left one small non-blocking suggestion.
| } | ||
|
|
||
| impl<T: Debug + Clone + PartialEq + Eq + PartialOrd> From<Option<T>> for Precision<T> { | ||
| fn from(option: Option<T>) -> Self { |
Contributor
There was a problem hiding this comment.
Small readability suggestion: this Option match can be collapsed without changing behavior. This keeps the mapping from Some to Exact and None to Absent pretty direct:
option.map_or(Precision::Absent, Precision::Exact)
Contributor
Author
There was a problem hiding this comment.
Sounds good, made the changes.
kosiew
approved these changes
Jun 9, 2026
AdamGS
pushed a commit
to AdamGS/arrow-datafusion
that referenced
this pull request
Jun 11, 2026
This commit adds a `From<Option<T>>` trait for `Precision`. Porting from `influxdb` to upstream: https://github.com/influxdata/influxdb/blob/70335b158808881c2f5a9ef27cd4bcbe4944686a/core/datafusion_util/src/lib.rs#L153-L163
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a
From<Option<T>>trait forPrecision. Porting frominfluxdbto upstream:https://github.com/influxdata/influxdb/blob/70335b158808881c2f5a9ef27cd4bcbe4944686a/core/datafusion_util/src/lib.rs#L153-L163