refactor(parquet): bundle array reader recursion args into ReaderArgs#10089
Open
HippoBaro wants to merge 1 commit into
Open
refactor(parquet): bundle array reader recursion args into ReaderArgs#10089HippoBaro wants to merge 1 commit into
ReaderArgs#10089HippoBaro wants to merge 1 commit into
Conversation
The recursive `build_reader` / `build_*_reader` methods in the array reader builder thread `field` and `mask` through every call. Bundle them into a small `Copy` `ReaderArgs` struct so the recursive signatures stay compact and there is a single, documented home for per-field reader options added in the future. This is a mechanical, behavior-preserving change: `build_array_reader` constructs the args at the entry point, group readers recurse with `args.with_field(child)`, and leaf readers read `args.field` and `args.mask`. No functional change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The recursive
build_reader/build_*_readermethods in the array reader builder threadfieldandmaskthrough every call.What changes are included in this PR?
Bundle them into a small
CopyReaderArgsstruct so the recursive signatures stay compact and there is a single, documented home for per-field reader options added in the future. This is a mechanical, behavior-preserving change:build_array_readerconstructs the args at the entry point, group readers recurse withargs.with_field(child), and leaf readers readargs.fieldandargs.mask.Are these changes tested?
All tests passing.
Are there any user-facing changes?
No.