feat(gcp): support explicit bearer token config in parse flow#717
Open
siddharthmittal13 wants to merge 1 commit into
Open
feat(gcp): support explicit bearer token config in parse flow#717siddharthmittal13 wants to merge 1 commit into
siddharthmittal13 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #716.
Rationale for this change
GCS already supported static bearer-token authentication through the builder, but there was no clean way to use it through the standard
parse_url_optsconfiguration flow. That forced downstream users to bypass the normal GCS parsing path and manually construct a builder, which risks drifting from the default option-handling behavior.This change adds explicit bearer-token support to the normal GCS config path so callers can keep using the standard parse/config flow.
What changes are included in this PR?
This PR adds support for configuring GCS with an explicit OAuth bearer token through the standard GCS config parsing path.
It also documents that an explicitly provided bearer token is treated as a static credential and is not refreshed automatically.
In addition, it adds test coverage for bearer-token configuration aliases and the parse-layer GCS flow.
Are there any user-facing changes?
Yes.
Users can now provide an explicit bearer token for GCS using supported config keys such as
google_bearer_tokenandbearer_tokenwhile continuing to use the normalparse_url_optspath.This token is treated as a static credential override and will not refresh automatically.
There are no breaking API changes.