Pluggable Crypto / Update reqwest 0.13#707
Open
goffrie wants to merge 8 commits into
Open
Conversation
|
Ping? Would be nice to avoid having duplicate reqwest versions in downstream projects. |
Author
|
I've given this another rebase, I think it's more blocked on review/maintainer capacity though? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this is a rebased version of #585
Which issue does this PR close?
Closes #413.
Rationale for this change
What changes are included in this PR?
Adds the ability to compile object_store without a dependency on ring, and instead use aws-lc-rs or a user-provided crypto implementation. Also changes the default to aws-lc-rs, which the ecosystem seems to be moving toward as a default.
Also upgrades
reqwestto 0.13, and makes it possible to configure reqwest with any TLS backend by selecting a-no-cryptofeature.Are there any user-facing changes?