fix: normalize qjson errors in request json#13407
Merged
nic-6443 merged 5 commits intoMay 21, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR normalizes qjson failures in apisix.core.request_json so callers consistently receive nil, err instead of uncaught Lua errors, aligning qjson behavior with expectations established by core.json-style helpers.
Changes:
- Wrap
qjson.decode,qjson.materialize, andqjson.encodewithpcalland convert thrown errors intonil, errreturns. - Add a
t/core/request.ttest to assert malformed JSON request bodies andqjsonencode/decode failures returnnil, errwithout emitting[error]logs. - Renumber subsequent request tests to account for the new coverage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
apisix/core/request_json.lua |
Adds guarded qjson decode/materialize/encode helpers to normalize thrown errors into nil, err. |
t/core/request.t |
Adds regression test coverage for qjson decode/encode error normalization and malformed JSON request body handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
membphis
approved these changes
May 21, 2026
AlinsRan
approved these changes
May 21, 2026
shreemaan-abhishek
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on the qjson review in #13386. qjson can raise Lua errors from decode/materialize/encode paths, while the request JSON helper callers expect the same
nil, errshape ascore.json.This patch wraps the qjson paths and normalizes those failures to
nil, err, while keeping cjson and simdjson behavior unchanged. It also adds a core request test for malformed request body decode and qjson encode failures.Checks run:
git diff --checkluacheck apisix/core/request_json.luaperl -I. -c t/core/request.t