Conversation
parsing index.d.ts via swc
(basically what's needed for code-sys to work vs what's not)
now that we know what's needed for vscode's index.d.ts
also make constructors return the class they're defined w/ instead of Any
qualified names type literals unions intersections parenthesized types
delete's the wasm module, we'll add that ir when we need it
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 29.04% 28.09% -0.96%
==========================================
Files 48 49 +1
Lines 11547 12075 +528
Branches 6436 6806 +370
==========================================
+ Hits 3354 3392 +38
- Misses 6039 6409 +370
- Partials 2154 2274 +120
Continue to review full report at Codecov.
|
anp
commented
Sep 7, 2020
| /// ``` | ||
| /// | ||
| /// For other uses see [`typescript::TsModule`] and TODO add back type for | ||
| /// wasm-bindgen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.