Skip to content

Allow override eventProperties #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmitriy-kiriyenko wants to merge 1 commit into from
Closed

Allow override eventProperties #449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions vendor/assets/javascripts/ahoy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,17 +298,6 @@
return obj;
}

function eventProperties(e) {
var target = e.target;
return cleanObject({
tag: target.tagName.toLowerCase(),
id: presence(target.id),
"class": presence(target.className),
page: page(),
section: getClosestSection(target)
});
}

function getClosestSection(element) {
for ( ; element && element !== document; element = element.parentNode) {
if (element.hasAttribute('data-section')) {
Expand Down Expand Up @@ -383,6 +372,17 @@
}
}

ahoy.eventProperties = function(e) {
var target = e.target;
return cleanObject({
tag: target.tagName.toLowerCase(),
id: presence(target.id),
"class": presence(target.className),
page: page(),
section: getClosestSection(target)
});
}

ahoy.getVisitId = ahoy.getVisitToken = function () {
return getCookie("ahoy_visit");
};
Expand Down Expand Up @@ -466,7 +466,7 @@
ahoy.trackClicks = function () {
onEvent("click", "a, button, input[type=submit]", function (e) {
var target = e.target;
var properties = eventProperties(e);
var properties = ahoy.eventProperties(e);
properties.text = properties.tag == "input" ? target.value : (target.textContent || target.innerText || target.innerHTML).replace(/[\s\r\n]+/g, " ").trim();
properties.href = target.href;
ahoy.track("$click", properties);
Expand All @@ -475,14 +475,14 @@

ahoy.trackSubmits = function () {
onEvent("submit", "form", function (e) {
var properties = eventProperties(e);
var properties = ahoy.eventProperties(e);
ahoy.track("$submit", properties);
});
};

ahoy.trackChanges = function () {
onEvent("change", "input, textarea, select", function (e) {
var properties = eventProperties(e);
var properties = ahoy.eventProperties(e);
ahoy.track("$change", properties);
});
};
Expand Down