Fix biometric wallet auth and DC API Chrome compatibility#521
Open
Wicpar wants to merge 3 commits intoanimo:mainfrom
Open
Fix biometric wallet auth and DC API Chrome compatibility#521Wicpar wants to merge 3 commits intoanimo:mainfrom
Wicpar wants to merge 3 commits intoanimo:mainfrom
Conversation
a946504 to
110a794
Compare
Contributor
Author
|
@TimoGlastra I have manually reviewed the changes as well as tested the changed flows. You can drop the second commit that just handles some errors more cleanly, as it is a bit iffy in error detection. |
8a3e320 to
cbbbf5e
Compare
This was referenced Apr 28, 2026
d5f3614 to
5d7ef41
Compare
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR centralizes wallet flow authorization around shared PIN/biometric components and helpers:
WalletPinPrompt,WalletFlowAuthPrompt, and flow authorization helpers.It also updates the SDK Digital Credentials API handling for current Chrome compatibility:
{ protocol, data }envelope.dc_api.jwtby returning the nestedresponsestring shape Chrome expects.Why
The biometric/PIN behavior had drifted across flows. Centralizing the auth prompt and authorization policy makes one-auth-per-flow behavior easier to maintain and avoids separate implementations for OpenID, offline, and DC API presentations.
The DC API update is required because newer Chrome versions reject the older response/request structure. Without the compatibility update, Chrome will refuse wallet responses even when credential selection and signing succeed. When a DC-API request fails before a valid response can be built, the user now gets the same style of error surface as other VP flows instead of a silent close.
Validation
pnpm exec biome check --unsafe apps/easypid/src/features/share/DcApiSharingScreen.tsx apps/easypid/src/features/receive/slides/InteractionErrorSlide.tsxpnpm types:checkgit diff --check upstream/main..HEAD