add patches attribute for pins#238
Draft
Janik-Haag wants to merge 2 commits into
Draft
Conversation
fixes a eval warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some glue code to make patching pins more convenient, motivated by #141.
I'm not too happy with passing pkgs and patches to every pin individually, but that seems like the most obvious path forward, since the api already exists.
Also, not sure if we want to couple patches and nixpkgs fetchers.
If we want to decouple them, but keep the same api, I'd probably add an attribute like
nixpkgsFetcher ? truetomkSource. This would keep the existing api compatible but would also allow the user to toggle the behavior if they wish to. I can imagine this being useful for the nixpkgs pin, so you can patch it without having to fetch it twice.The test is a bit shit, before merging it should probably be improved. Currently, if the patch can't be applied it still succeeds and is completely silent about the failure in the logs (bash is horrible).