This repository was archived by the owner on Jul 11, 2024. It is now read-only.
chore: enforce naming concistency#432
Draft
andersfylling wants to merge 6 commits intomasterfrom
Draft
Conversation
5 tasks
Owner
Author
|
I think this could be a nice idea, but I would like to be able to map which types are REST calls and which are events. |
andersfylling
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently came across some variables names that used the same convention as some rest params. Given that there are.. probably hundreds of vars/consts and well over a hundred types, I'm adding a new way to enforce naming convention for certain types using go generate.
This is going to cause a breaking change and will take some time to clean up. If the rework is too massive, I might dismiss this PR and figure out a simpler solution.