linux/efa: Add support for building with Clang/LLVM#366
Open
mjonuschat wants to merge 2 commits into
Open
Conversation
KBUILD_CPPFLAGS is a global kbuild variable. Setting it in an out-of-tree module Makefile affects all files in the build invocation, not just the conftest module. Use ccflags-y which is the correct per-module kbuild idiom.
The conftest Makefile does not forward CC, LD, or LLVM variables to the sub-make invocation. When the kernel is built with Clang/LLVM, the conftest module is still compiled with the system default GCC, potentially detecting the wrong set of kernel features. Forward CC, LD, and LLVM to the kbuild sub-make so the conftest is compiled with the same toolchain as the driver. Additionally, make the warning flag suppression conditional: use -Wno-maybe-uninitialized for GCC (which does not exist in Clang) and -Wno-unused-value for Clang.
mjonuschat
force-pushed
the
feature/clang
branch
from
00f4427 to
50e292a
Compare
mjonuschat
changed the title
mjonuschat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #365
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.