feat(rpc-types-engine): add hidden setters to ExecutionPayload#3875
Merged
feat(rpc-types-engine): add hidden setters to ExecutionPayload#3875
Conversation
Adds doc-hidden setter helpers for ExecutionPayload fields so test code (e.g. reth-bench's payload invalidation) can mutate fields without manually matching on each variant.
mattsse
requested review from
DaniPopes,
grandizzy,
klkvr,
onbjerg and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds doc-hidden setter helpers on
ExecutionPayloadfor fields that test code commonly mutates. Currently consumers like reth-bench's payload invalidation logic match on each variant manually to mutate inner fields; these helpers let callers dopayload.set_block_hash(hash)instead.V1 fields are always settable. V2 (
set_withdrawals) and V3 (set_blob_gas_used,set_excess_blob_gas) helpers returnboolindicating whether the variant supported the field. All setters are marked#[doc(hidden)]since they are only intended for testing.