Skip to content

fix(json-rpc): propagate key parse errors in PubSubItem deserializer#3818

Open
neowangreal wants to merge 5 commits intoalloy-rs:mainfrom
neowangreal:propagate
Open

fix(json-rpc): propagate key parse errors in PubSubItem deserializer#3818
neowangreal wants to merge 5 commits intoalloy-rs:mainfrom
neowangreal:propagate

Conversation

@neowangreal
Copy link
Copy Markdown
Contributor

The visit_map implementation used while let Ok(Some(key)) to iterate map keys, which causes Err from next_key() to silently break the loop instead of propagating the error. This could lead to misleading downstream errors (e.g., "missing field params") instead of the actual parse error.

inconsistent with all next_value()? calls in the same function, and with the idiomatic serde visitor pattern used elsewhere in the repo.

@github-project-automation github-project-automation bot moved this to Reviewed in Alloy Mar 20, 2026
@neowangreal
Copy link
Copy Markdown
Contributor Author

Rebase @mattsse

@neowangreal neowangreal requested a review from mattsse March 28, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Reviewed

Development

Successfully merging this pull request may close these issues.

2 participants