fix(json-rpc): propagate key parse errors in PubSubItem deserializer#3818
Open
neowangreal wants to merge 5 commits intoalloy-rs:mainfrom
Open
fix(json-rpc): propagate key parse errors in PubSubItem deserializer#3818neowangreal wants to merge 5 commits intoalloy-rs:mainfrom
neowangreal wants to merge 5 commits intoalloy-rs:mainfrom
Conversation
mattsse
approved these changes
Mar 20, 2026
Contributor
Author
|
Rebase @mattsse |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
visit_mapimplementation usedwhile let Ok(Some(key))to iterate map keys, which causesErrfromnext_key()to silently break the loop instead of propagating the error. This could lead to misleading downstream errors (e.g., "missing fieldparams") instead of the actual parse error.inconsistent with all
next_value()?calls in the same function, and with the idiomatic serde visitor pattern used elsewhere in the repo.