refactor(network): extract NetworkTransactionBuilder from TransactionBuilder#3344
Merged
mattsse merged 10 commits intoalloy-rs:mainfrom Apr 9, 2026
Merged
refactor(network): extract NetworkTransactionBuilder from TransactionBuilder#3344mattsse merged 10 commits intoalloy-rs:mainfrom
NetworkTransactionBuilder from TransactionBuilder#3344mattsse merged 10 commits intoalloy-rs:mainfrom
Conversation
lean-apple
changed the title
lean-apple
changed the title
NetworkTransactionBuilder from TransactionBuilder
Draft
3 tasks
lean-apple
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
Contributor
|
rebased this locally and looks complete, just needs the conflicts |
Closed
3 tasks
klkvr
reviewed
Apr 8, 2026
mattsse
approved these changes
Apr 9, 2026
klkvr
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3331.
Solution
Split
TransactionBuilderinto 2 traits, one new,NetworkTransactionBuilder, with methods depending on network, the other with the other methods.PR Checklist