Skip to content

See if we can write without a user (using api keys) #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benmerckx wants to merge 4 commits into
base: main
Choose a base branch
from
+17,934 −3
Open

See if we can write without a user (using api keys) #489

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
700630a
See if we can write without a user (using api keys)
benmerckx Apr 14, 2026
5257bac
plan: add mutate handler tests
Copilot Apr 14, 2026
67e0b65
test: add mutate handler tests for user auth and api key auth
Copilot Apr 14, 2026
5d03bda
fix: correct spelling in comment
Copilot Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/backend/Handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,9 @@ export function createHandler({
}

if (action === HandleAction.Mutate && request.method === 'POST') {
const user = expectUser()
const user = userCtx?.user
expectJson()
const policy = await local.createPolicy(user.roles)
const policy = user && (await local.createPolicy(user.roles))
const mutations = await body
Comment on lines 167 to 171

Copilot AI Apr 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a new auth mode for mutate (API key without a user), but there are no tests covering the permission behavior and expected status codes for this path. Please add handler tests exercising action=mutate with (1) a verified user (policy enforced) and (2) API-key-only auth, asserting the intended permission model (deny by default vs allow-all vs specific role).

Copilot uses AI. Check for mistakes.
const attempt = async (retry = 0) => {
await local.syncWith(cnx)
Expand Down
Loading