NodeEditor: Display GroupAttribute as collapsible sections instead of nested key/value pairs#3069
Draft
NodeEditor: Display GroupAttribute as collapsible sections instead of nested key/value pairs#3069
Conversation
…value pairs Agent-Logs-Url: https://github.com/alicevision/Meshroom/sessions/0e1e67f7-0a33-454b-8a0b-eb604b999520 Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
fabiencastan
April 1, 2026 21:53
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grouped attributes in the NodeEditor were rendered as nested key/value structures, repeating hierarchy labels and wasting vertical space. This replaces that with collapsible section headers containing child attributes directly.
Description
GroupAttributeentries are now displayed as collapsible section headers (expand/collapse toggle + bold group name) with their children listed below, indented, instead of a flat key → nested-key/value layout. Groups expand by default; users can collapse to reclaim space.Features list
AttributeEditorindented (8 px left margin) and collapsed/expanded in sync with the section togglelabelWidthpropagated from parent instead of hardcoded100showInViewersignal now forwarded from nestedAttributeEditor(was missing)attributeDoubleClickedhandler to correctly pass bothmouseandattr(previouslymousewas silently dropped)Implementation remarks
groupAttributeComponentinAttributeItemDelegate.qmlis replaced with aColumnLayoutcontaining a static headerRowLayoutand a dynamically-createdAttributeEditor(dynamic creation retained to avoid the existing circular-import betweenAttributeItemDelegate↔AttributeEditor). The child editor'svisibleis bound togroupItem.expandedso the ColumnLayout naturally excludes it from height calculation when collapsed.The left label
Panegainsvisible: attribute.type !== "GroupAttribute"so it is excluded from theRowLayoutlayout, letting the group component fill full width without a redundant label column.