Allow drag & drop files on InitNode in the GraphEditor#3068
Allow drag & drop files on InitNode in the GraphEditor#3068
Conversation
Agent-Logs-Url: https://github.com/alicevision/Meshroom/sessions/994421f1-d823-4916-9b75-b2361dae8e82 Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
…n fix) Agent-Logs-Url: https://github.com/alicevision/Meshroom/sessions/4e5cb15f-efc7-4ceb-aac3-4a81dc441afa Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3068 +/- ##
===========================================
- Coverage 83.40% 83.39% -0.01%
===========================================
Files 73 73
Lines 9870 9873 +3
===========================================
+ Hits 8232 8234 +2
- Misses 1638 1639 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cbentejac
left a comment
There was a problem hiding this comment.
This implementation always re-initializes the InitNode when files/images are dropped through the initialize() method. Shouldn't we also want to be able to extend the current input with the files/images we are dropping?
We could assume that the current behaviour is the default one, but if files/images are dropped while pressing a specific key, then the behaviour changes to an extendAttributes() instead of an initalize().
| node (Node): the InitNode to initialize | ||
| urls (list of QUrl): the list of dropped file/directory URLs | ||
| """ | ||
| if not isinstance(node.nodeDesc, meshroom.core.desc.InitNode): |
There was a problem hiding this comment.
| if not isinstance(node.nodeDesc, meshroom.core.desc.InitNode): | |
| if not node.isInitNode: |
initNodeDragHoverproperty and highlight rectangleinitNodeDelegateAt()helper function to GraphEditor.qmlinitializeNodeon droponPositionChanged/onExitedto GraphEditor's DropArea for visual feedback