Skip to content

Add flowIn/flowOut Flow attribute pins to every node, displayed in the node header#3048

Draft
Copilot wants to merge 7 commits intodevelopfrom
copilot/add-flow-attribute-type
Draft

Add flowIn/flowOut Flow attribute pins to every node, displayed in the node header#3048
Copilot wants to merge 7 commits intodevelopfrom
copilot/add-flow-attribute-type

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 18, 2026

  • Rename FlowAttributeFlow in desc/attribute.py and attribute.py (+ backward-compat alias)
  • Update all imports, isinstance checks, comments, and QML type strings to use "Flow"
  • Move flow input/output attrs from _attributes to _internalAttributes in node.py
  • Update node.py _applyExpr() to also iterate over _internalAttributes
  • Fix attribute.py _applyExpr() to search _internalAttributes when looking for source attr
  • Update QML Node.qml to use internalAttribute()/hasInternalAttribute() for flowIn/flowOut
  • Update nodeFactory.py compatibility checks to account for flow attrs in internalInputs
  • Remove if v is not None filter from outputs in toDict()
  • Update tests (test_flowAttribute.py, test_compatibility.py, test_pipeline.py)
  • All 257 backend tests pass, CodeQL: 0 alerts

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Copilot AI and others added 2 commits March 18, 2026 21:16
Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
…ments

Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Copilot AI changed the title [WIP] Add new attribute type named Flow Add FlowAttribute type for no-data node dependency edges Mar 18, 2026
Copilot AI requested a review from fabiencastan March 18, 2026 21:19
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 98.72340% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.78%. Comparing base (63031e1) to head (9f2c140).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/nodeFactory.py 89.47% 2 Missing ⚠️
meshroom/core/attribute.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3048      +/-   ##
===========================================
+ Coverage    83.40%   83.78%   +0.37%     
===========================================
  Files           73       74       +1     
  Lines         9870    10101     +231     
===========================================
+ Hits          8232     8463     +231     
  Misses        1638     1638              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI and others added 2 commits March 18, 2026 22:09
…ibutesFactory

Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Copilot AI changed the title Add FlowAttribute type for no-data node dependency edges Add FlowAttribute type and automatic flowIn/flowOut pins on every node Mar 18, 2026
Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Copilot AI changed the title Add FlowAttribute type and automatic flowIn/flowOut pins on every node Add flowIn/flowOut Flow attribute pins to every node, displayed in the node header Mar 18, 2026
…None from outputs

Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants