[core] Fix dynamic attributes on loading file#3044
Draft
Conversation
|
Contributor
Author
|
Just a small review : after discussing with @fcastan he exposed that it might lower graph performances, so we will keep this as draft for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The bug I got happened on the specific situation where we have :
And then NodeA.out -> NodeB.in
In this case what seems to happen is :
NodeA.out -> NodeB.in."{node.scene.value}"is set to None at first because we haven't computed the upstream value yetProposed fix
With this PR we force an update from internal params and output params after loading the scene. Loading internal params is enough for the bug I encountered but maybe we also need updateOutputAttr too.
Maybe there are better ways to do it if any reviewer have an idea let me know