Skip to content

Enable connecting multiple list Attributes#3000

Draft
servantftransperfect wants to merge 1 commit intodevelopfrom
dev/multipleListAttributes
Draft

Enable connecting multiple list Attributes#3000
servantftransperfect wants to merge 1 commit intodevelopfrom
dev/multipleListAttributes

Conversation

@servantftransperfect
Copy link
Copy Markdown
Contributor

Enable the connection of multiple listAttributes to the same destination listAttribute

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 87.77778% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.21%. Comparing base (912a71d) to head (35cf5ba).
⚠️ Report is 51 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/graph.py 68.57% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3000      +/-   ##
===========================================
+ Coverage    82.01%   83.21%   +1.19%     
===========================================
  Files           69       70       +1     
  Lines         9310    10144     +834     
===========================================
+ Hits          7636     8441     +805     
- Misses        1674     1703      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cbentejac
Copy link
Copy Markdown
Contributor

This seems to work correctly, including when performing undos and redos, but some unit tests should definitely be added.

@Alxiice Alxiice closed this Mar 2, 2026
@Alxiice Alxiice deleted the dev/multipleListAttributes branch March 2, 2026 14:51
@servantftransperfect servantftransperfect restored the dev/multipleListAttributes branch March 2, 2026 14:56
Copy link
Copy Markdown
Member

@fabiencastan fabiencastan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, it is not a good idea to create connections between lists and, in some cases, between elements within the lists, without providing the end user with any information. This leads to errors and confusion.

@fabiencastan
Copy link
Copy Markdown
Member

In the short term, I would recommend to create a node with a list<list> in input that creates a flatten list in output.

@fabiencastan
Copy link
Copy Markdown
Member

#3061

@fabiencastan fabiencastan marked this pull request as draft March 29, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants