geosearch

[alicebob]

For #354, probably will take a while.

[timwangmusic]

Hello, any plan to complete this feature soon?

[alicebob]

hi @timwangmusic, I forgot about this on (got sidetracked back then). Maybe if I have some spare energy, but don't hold your breath...

[evan-choi]

Hi @alicebob,

Before I spend more time on #354, I wanted to check whether this direction would be welcome.

From a first pass, it looks difficult to add GEOSEARCH / GEOSEARCHSTORE cleanly without also touching the existing GEORADIUS* path. So instead of a very small command-only change, I’m considering a PR that would:

• add GEOSEARCH and GEOSEARCHSTORE
• introduce a shared geo search path for GEORADIUS* and GEOSEARCH*
• port a larger set of Redis 8.4.0 parity tests from tests/unit/geo.tcl
• include the related geo store keyevent cases from tests/unit/pubsub.tcl

I would keep the scope limited to the geo search command family, not unrelated ACL/metadata work.

Would a PR in that shape be useful, or would you prefer something narrower?

[alicebob]

On Sun, Mar 22, 2026 at 12:55:41AM -0700, Evan wrote: evan-choi left a comment (alicebob/miniredis#359) Hi @alicebob, Before I spend more time on #354, I wanted to check whether this direction would be welcome. >From a first pass, it looks difficult to add `GEOSEARCH` / `GEOSEARCHSTORE` cleanly without also touching the existing `GEORADIUS*` path. So instead of a very small command-only change, I’m considering a PR that would: - add `GEOSEARCH` and `GEOSEARCHSTORE` - introduce a shared geo search path for `GEORADIUS*` and `GEOSEARCH*` - port a larger set of Redis 8.4.0 parity tests from `tests/unit/geo.tcl` - include the related geo store keyevent cases from `tests/unit/pubsub.tcl` I would keep the scope limited to the geo search command family, not unrelated ACL/metadata work. Would a PR in that shape be useful, or would you prefer something narrower?

Thanks for (potentially) taking this on! Please make the changes as small as you can manage, that makes my task much easier.