Skip to content

Hotfix/update file saver module#49

Open
elquimeras wants to merge 8 commits into
alferov:masterfrom
elquimeras:hotfix/update-file-saver-module
Open

Hotfix/update file saver module#49
elquimeras wants to merge 8 commits into
alferov:masterfrom
elquimeras:hotfix/update-file-saver-module

Conversation

@elquimeras

@elquimeras elquimeras commented Apr 21, 2022

Copy link
Copy Markdown

🤔 Problem

  • FileSaver.js package was outdated from Teleborder repository
bower file-saver.js#~1.20150507.2                      
ECMDERR Failed to execute "git ls-remote --tags --heads https://github.com/Teleborder/FileSaver.js.git", exit code of #128 remote: Repository not found. fatal: repository 'https://github.com/Teleborder/FileSaver.js.git/' not found

✅ Solution

  • Update FileSaver to latest version and use the new npm location https://github.com/eligrey/FileSaver.js

@clarify-ankush

Copy link
Copy Markdown

+1

4 similar comments
@seanfeld

seanfeld commented Apr 21, 2022

Copy link
Copy Markdown

+1

@AhsanulChowdhury-rogers

Copy link
Copy Markdown

+1

@leninr0a

Copy link
Copy Markdown

+1

@shaapala

Copy link
Copy Markdown

+1

@nescalera

Copy link
Copy Markdown

@alferov - Can we please get this PR merged?

@neatcoder

neatcoder commented Jul 7, 2022

Copy link
Copy Markdown

Hey @alferov! Can we fix this?
We are using Jfrog artifactory to cache the bower packages. We can not use the workaround of directly pulling from the downstream as @elquimeras 's fork and this StackOverflow post suggests because of firewall constraints. It would save us a lot of time and trouble if we can merge this. Thanks!! ❤️

@elquimeras

Copy link
Copy Markdown
Author

Hey @alferov! Can we fix this?
We are using Jfrog artifactory to cache the bower packages. We can not use the workaround of directly pulling from the downstream as @elquimeras 's fork and this StackOverflow post suggests because of firewall constraints. It would save us a lot of time and trouble if we can merge this. Thanks!! ❤️

I couldn't create a forked bower new package because is deprecated =( I hope alferov could update the original too. On npm is here https://www.npmjs.com/package/ng-file-saver

@RoketV RoketV left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, guys, merge it as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants