Conversation
… metadata support, and improve permission constants
There was a problem hiding this comment.
Pull request overview
This PR extends the ACL bundle to support arbitrary per-ACE metadata persisted in the database and exposed via the API/serializer, along with a few related API and type tweaks in the permission layer.
Changes:
- Add
metadatatoAccessControlEntry(entity + interface), persist it via the Doctrine repository, accept it viaPermissionController, and return it viaAceSerializer. - Extend
PermissionManager::isGranted()with an$ownershipGrantsflag and add aresetCache()helper. - Introduce a new
CHILD_VIEWpermission constant (but with shifted bitmask values for existing child permissions).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Serializer/AceSerializer.php | Includes ACE metadata in serialized payloads. |
| src/Security/Voter/SetPermissionVoter.php | Adds typed constant declarations for voter attributes. |
| src/Security/PermissionManager.php | Adds cache reset, ownership bypass flag, and threads metadata through ACE upsert. |
| src/Security/PermissionInterface.php | Adds CHILD_VIEW and updates permission bitmask constants/mapping. |
| src/Repository/PermissionRepositoryInterface.php | Extends repository upsert API to accept metadata. |
| src/Repository/DoctrinePermissionRepository.php | Persists metadata to ACE rows on upsert. |
| src/Model/AccessControlEntryInterface.php | Adds metadata getters/setters to the ACE contract. |
| src/Entity/AccessControlEntry.php | Adds metadata JSON column + accessor methods; updates some Doctrine type declarations. |
| src/Controller/PermissionController.php | Accepts metadata in PUT /ace requests and passes it to the manager. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.