Better local group selection#1162
Merged
Merged
Conversation
Member
dfellis
commented
May 1, 2026
dfellis
commented
- Better local group selection based on GPU capabilities and global workgroup size
- Attempt to remove the hardwired local group sizing and the sentinel hackery for the window and frame
…ackery for the window and frame
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Clamp to [8, maxInvocations] | ||
| target = target.max(8).min(max_invocations); | ||
| // Snap to nearest multiple of 8 (hardware alignment) | ||
| target = ((target + 7) / 8) * 8; |
| if sqrt >= 8 && sqrt * sqrt == target { | ||
| return [sqrt as i64, sqrt as i64, 1]; | ||
| } | ||
| if target % 8 == 0 { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.