Fix Duration equals and compareTo when values differ by very little#33
Open
findepi wants to merge 2 commits into
Open
Fix Duration equals and compareTo when values differ by very little#33findepi wants to merge 2 commits into
findepi wants to merge 2 commits into
Conversation
Comparing by `getValue(MILLISECONDS)` is not sufficient to distinguish shorter durations, or duration with difference smaller than milliseconds. Additionally, this changes `getValue` itself. Multiplication with `millisPerTimeUnit` division was introducing additional double math error, so was replaced with as direct as possible calculation.
findepi
force-pushed
the
findepi/equals-nano-precision
branch
from
79ecca1 to
0b93efc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.