Update PHP_CodeSniffer repository link#111
Conversation
75df31f to
b1ff751
Compare
aik099
left a comment
There was a problem hiding this comment.
You've changed the owner (from squizlabs into PHPCSStandards( in the link, but both links lead to 404 Page Not Found page.
Please investigate and see how to fix that link while preserving your intention (of link fixing) and original idea behind the link itself.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
=========================================
Coverage 97.73% 97.73%
Complexity 498 498
=========================================
Files 29 29
Lines 1460 1460
=========================================
Hits 1427 1427
Misses 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@aik099, I'm sorry for missing that the original and the new link are broken. While investigating the broken link, I looked into the history of the PHPCS standard to find the right URL to link to. Please correct me if I missed something, but below is what I found. The I don't have much of the context of why this repo linked to the PHPCS standard. I opened this PR as part of an effort to update links referencing the old repo to the new one in several repositories. Given all that, do you prefer that the link points to the PHPCS standard on the Thanks |
|
The best match would be https://github.com/PHPCSStandards/PHP_CodeSniffer/tree/2.9/CodeSniffer/Standards/PHPCS link then, because it is the last place where this standard existed in the new repo. Please use it. |
b1ff751 to
51be1ff
Compare
|
Thanks, I applied the change you suggested. Since the changes in this PR are small, I opted to amend the original commit and force push. |
|
Merging. Thank you @rodrigoprimo . |
PHP_CodeSniffer has moved to a new GitHub organization. The
squizlabs/PHP_CodeSnifferrepository is now archived and the project is actively maintained at https://github.com/PHPCSStandards/PHP_CodeSniffer.See: squizlabs/PHP_CodeSniffer#3932