Reduce API calls by fetching all jobs in single request #127
Draft
khsrali wants to merge 2 commits intoaiidateam:mainfrom
Draft
Reduce API calls by fetching all jobs in single request #127khsrali wants to merge 2 commits intoaiidateam:mainfrom
khsrali wants to merge 2 commits intoaiidateam:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 82.03% 82.19% +0.16%
==========================================
Files 4 4
Lines 846 848 +2
==========================================
+ Hits 694 697 +3
+ Misses 152 151 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Update: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of making individual API requests per job ID, now fetch all jobs
in a single request and filter locally. This reduces the number of API
calls to the FirecREST server.
Also improves the retry logic: