refactor: remove empty bot constructors that only call super()#1078
Open
octo-patch wants to merge 1 commit into
Open
refactor: remove empty bot constructors that only call super()#1078octo-patch wants to merge 1 commit into
octo-patch wants to merge 1 commit into
Conversation
Removes unnecessary boilerplate constructors across 78 bot files where the constructor only calls super() with no additional initialization. JavaScript classes automatically invoke the parent constructor when no constructor is defined, so these are redundant. Closes ai-shifu#1008
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (78)
💤 Files with no reviewable changes (78)
📝 WalkthroughWalkthroughRemoved redundant Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes redundant constructors that only call super() across a large number of bot implementation files. This is a standard code cleanup that simplifies class definitions while maintaining identical behavior. As there are no review comments to evaluate, I have no further feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1008
Problem
Many bot files contain boilerplate constructors that only call
super()with no additional initialization logic:This was flagged in #1005 and #1012 by CodeRabbit and tracked in issue #1008. JavaScript classes automatically invoke the parent constructor when no constructor is defined, making these redundant.
Solution
Removed the empty
constructor() { super(); }blocks from 78 bot files across the codebase. The behavior is identical — JavaScript's default constructor callssuper()automatically for derived classes.Testing
super()call and nothing else) were removedSummary by CodeRabbit