fix: separate server connection config#1778
Draft
markpmarton wants to merge 4 commits into
Draft
Conversation
Signed-off-by: Mark Marton <mark.p.marton@gmail.com>
Signed-off-by: Mark Marton <mark.p.marton@gmail.com>
Signed-off-by: Mark Marton <mark.p.marton@gmail.com>
Signed-off-by: Mark Marton <30534230+markpmarton@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR separates server-side connection requirements from client connection policy by introducing
ServerConnectionConfigas a dedicated type, distinct fromClientConfig.Previously, the full
ClientConfig(including client-local settings like Spire socket paths, backoff, keepalive) was serialized and stored in the database and passed over the wire. Now the control plane stores and transmits only what the server requires — endpoint, TLS flag, and auth method — while the controller merges those requirements onto its own local ClientConfig when opening a connection.Changes
ServerConnectionConfigtype containing only remote connection related fieldsConnectionDetailsdb schemaSpireMtlsnested field is replaced with three flat fields (tls_required,auth_methodandspire_trust_domain)generate_config_datasimplified: unusedsrc_noderemovedtls_required == trueis now mandatory ifauth_methodis SpireType of Change
Checklist