feat: add websocket supports for the browser#1775
Open
hackeramitkumar wants to merge 3 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| break; | ||
| } | ||
| } | ||
| Err(err) => { |
| Some(Ok(gloo_net::websocket::Message::Text(_))) => { | ||
| warn!("ignoring text websocket frame, expected binary protobuf frame"); | ||
| } | ||
| Some(Err(err)) => { |
| }; | ||
|
|
||
| let payload = msg.encode_to_vec(); | ||
| if let Err(err) = sink |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
hackeramitkumar
changed the title
Signed-off-by: amitami2 <amitami2@cisco.com>
Signed-off-by: amitami2 <amitami2@cisco.com>
Signed-off-by: amitami2 <amitami2@cisco.com>
amitami2
force-pushed
the
feat/browser-websocket-uniffi
branch
from
145fc32 to
524513f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a meaningful description of what this change will do, or is for.
Bonus points for including links to related issues, other PRs, or technical
references.
Note that by not including a description, you are asking reviewers to do extra
work to understand the context of this change, which may lead to your PR taking
much longer to review, or result in it not being reviewed at all.
Type of Change
Checklist