Add Pi types for iterative sets#1306
Draft
flgrubm wants to merge 7 commits into
Draft
Conversation
…ossy-unification`
…--lossy-unification` [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds codes for Pi types for iterative sets. They were originally part of #1300, but I separated them out due to termination issues with type checking for that module.
Right now, this is still a draft and the file still does not type check within a reasonable amount of time (despite using
--lossy-unification). I already got individual overlapping parts to type check, so I would assume that the whole file should be correct as well.This might also be connected to issues with slow unification in the (already upstream) modules
Cubical.Data.IterativeSets.UnorderedPair.BaseandCubical.Data.IterativeSets.OrderedPair, both of which compile quickly with lossy unification, but take a long time without.