BooleanAlgebraStr now infers the underlying set#1297
Open
Freek98 wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
@felixwellen is this a standard way to work with such instance resolution in the algebra libraries (Evan advised me to ask you). |
Collaborator
|
Looks good to me - you might get problems with type inference for homomorphisms (e.g. when you use composition). But you can still fix that later by making an extra record type for homs of boolean rings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BooleanAlgebraStr was based on a Boolean Ring, which is a tuple consisting of a type and a witness that this type is a Boolean Ring. The problem with this is that instances get difficult to resolve. Now instead, the type (first element of the tuple) is an implicit argument and the structure (second element of the tuple) is explicit, and instances are resolved without hassle.