[MNT] Add test to check that soft dependency skipping is working as intended#3411
Open
MatthewMiddlehurst wants to merge 14 commits into
Open
[MNT] Add test to check that soft dependency skipping is working as intended#3411MatthewMiddlehurst wants to merge 14 commits into
MatthewMiddlehurst wants to merge 14 commits into
Conversation
Contributor
Thank you for contributing to
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #3406 #3409 #3410
Adds a test run that simply checks no tests are skipped containing the reason "soft dependency" or similar when all dependencies are installed.
Skips all actual tests after the initial pytest check for skipping.
pytest checks generated by out testing system no longer xfail (still runs but expected to fail) but skips (does not run at all). I honestly thought we were already skipping and we have never run into and unexpected pass I believe.
Only wraps tests if the pytest flag is set.