Skip to content

[BUG] add raise of softdep not working when we install all extras#3409

Open
baraline wants to merge 2 commits into
mainfrom
ag-fix-softdep-testing
Open

[BUG] add raise of softdep not working when we install all extras#3409
baraline wants to merge 2 commits into
mainfrom
ag-fix-softdep-testing

Conversation

@baraline
Copy link
Copy Markdown
Member

@baraline baraline commented May 20, 2026

Reference Issues/PRs

Related to #3406

What does this implement/fix? Explain your changes.

While running tests in CI on environment where we install all_extras, we didn't raise when softdep checks failed, as they had severity=None in the test files. Added a flag to make these test raise.

One issue is that it's kind of the point of the softdeps checks, as some of these are OS dependent. But the linked issue showed that it can hide real failures. So with this PR we basically say, we trust one OS (here ubuntu) to be able to take all softdeps.

This is more of a quickfix. Maybe a better future solution would be to label those test under different pytest marks (e.g. @pytest.mark.softdepschecks with additional marks for specific OS) that would only run on these CI environment using all_extras.

This PR CI should fail due to the "hugging-face" softdep check.

@baraline baraline requested a review from a team as a code owner May 20, 2026 21:07
@baraline baraline changed the title add raise of softdep not working when we install all extras [BUG] add raise of softdep not working when we install all extras May 20, 2026
@aeon-actions-bot aeon-actions-bot Bot added the bug Something isn't working label May 20, 2026
@aeon-actions-bot
Copy link
Copy Markdown
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ bug ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, please run pre-commit locally and push the fixes to your PR branch.

Don't hesitate to ask questions on the aeon Discord channel if you have any.

PR CI actions

These checkboxes will add labels to enable or disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Disable numba cache loading
  • Regenerate expected results for testing
  • Push an empty commit to re-run CI checks

@baraline baraline added testing Testing related issue or pull request full pytest actions Run the full pytest suite on a PR labels May 20, 2026
@hadifawaz1999
Copy link
Copy Markdown
Member

we had this issue 2 years ago with tensorflow-addons, where it was actually a _ instead of -, and so the tests were not running without us knowing :)

@baraline
Copy link
Copy Markdown
Member Author

If we are OK with it, we can get this one in to check for that while we discuss a better solution. It is supposing we have all soft deps on ubuntu, but for now it is the case. This way we can move forward with the MONSTER data issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working full pytest actions Run the full pytest suite on a PR testing Testing related issue or pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants