You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What does this implement/fix? Explain your changes.
While running tests in CI on environment where we install all_extras, we didn't raise when softdep checks failed, as they had severity=None in the test files. Added a flag to make these test raise.
One issue is that it's kind of the point of the softdeps checks, as some of these are OS dependent. But the linked issue showed that it can hide real failures. So with this PR we basically say, we trust one OS (here ubuntu) to be able to take all softdeps.
This is more of a quickfix. Maybe a better future solution would be to label those test under different pytest marks (e.g. @pytest.mark.softdepschecks with additional marks for specific OS) that would only run on these CI environment using all_extras.
This PR CI should fail due to the "hugging-face" softdep check.
baraline
changed the title
add raise of softdep not working when we install all extras
[BUG] add raise of softdep not working when we install all extras
May 20, 2026
I have added the following labels to this PR based on the title: [ bug ].
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit code quality check fails, please run pre-commit locally and push the fixes to your PR branch.
Don't hesitate to ask questions on the aeonDiscord channel if you have any.
PR CI actions
These checkboxes will add labels to enable or disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
If we are OK with it, we can get this one in to check for that while we discuss a better solution. It is supposing we have all soft deps on ubuntu, but for now it is the case. This way we can move forward with the MONSTER data issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugSomething isn't workingfull pytest actionsRun the full pytest suite on a PRtestingTesting related issue or pull request
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #3406
What does this implement/fix? Explain your changes.
While running tests in CI on environment where we install all_extras, we didn't raise when softdep checks failed, as they had severity=None in the test files. Added a flag to make these test raise.
One issue is that it's kind of the point of the softdeps checks, as some of these are OS dependent. But the linked issue showed that it can hide real failures. So with this PR we basically say, we trust one OS (here ubuntu) to be able to take all softdeps.
This is more of a quickfix. Maybe a better future solution would be to label those test under different pytest marks (e.g. @pytest.mark.softdepschecks with additional marks for specific OS) that would only run on these CI environment using all_extras.
This PR CI should fail due to the "hugging-face" softdep check.