Skip to content

[BUG] Fix error in soft dependencies for HF hub in monster loader - #3408

Merged
baraline merged 4 commits into
aeon-toolkit:mainfrom
Cyril-Meyer:monster-dep-huggingface-hub
May 24, 2026
Merged

[BUG] Fix error in soft dependencies for HF hub in monster loader #3408
baraline merged 4 commits into
aeon-toolkit:mainfrom
Cyril-Meyer:monster-dep-huggingface-hub

Conversation

@Cyril-Meyer

Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Fixes #3406

What does this implement/fix? Explain your changes.

Replace "-" with "_"

Does your contribution introduce a new dependency? If yes, which one?

No, but I have discovered another error in dependency check

Any other comments?

Do not close issue, still things going on

PR checklist

For all contributions
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

@aeon-actions-bot aeon-actions-bot Bot added bug Something isn't working datasets Datasets and data loaders labels May 20, 2026
@aeon-actions-bot

Copy link
Copy Markdown
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ bug ].
I have added the following labels to this PR based on the changes made: [ datasets ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, please run pre-commit locally and push the fixes to your PR branch.

Don't hesitate to ask questions on the aeon Discord channel if you have any.

PR CI actions

These checkboxes will add labels to enable or disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Disable numba cache loading
  • Regenerate expected results for testing
  • Push an empty commit to re-run CI checks

baraline
baraline previously approved these changes May 20, 2026

@baraline baraline left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confusion between pypi package name and actual python import in the original code cause the issue. LGTM

@baraline

Copy link
Copy Markdown
Member

hey @Cyril-Meyer, we opened #3410 to think a bit more on how to handle this testing issue better.
In the meantime, could you also fix the bug on the imaginary import so this doesn't crash the CI ?

@Cyril-Meyer

Copy link
Copy Markdown
Contributor Author

hey @Cyril-Meyer, we opened #3410 to think a bit more on how to handle this testing issue better. In the meantime, could you also fix the bug on the imaginary import so this doesn't crash the CI ?

@baraline I just removed the import and replaced the usage of exception with a generic Exeception as e.

Not sure if that was what you mean by your request.

@baraline baraline added the full pytest actions Run the full pytest suite on a PR label May 24, 2026

@baraline baraline left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@baraline
baraline merged commit 4649950 into aeon-toolkit:main May 24, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working datasets Datasets and data loaders full pytest actions Run the full pytest suite on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] error in soft dependencies check for HF hub in monster loader

2 participants