-
Notifications
You must be signed in to change notification settings - Fork 249
feat(tooltip): documentation, consumer migration guide #6345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+515
−52
Merged
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
89b00b7
feat(tooltip): add tests
5t3ph 7a97f7b
feat(tooltip): code conformance
5t3ph d8ed6a6
feat(tooltip): documentation
5t3ph 0722db7
feat(tooltip): add consumer migration guide
5t3ph b65ae53
feat(tooltip): enable event tracking in Actions panel; test for all e…
5t3ph 5518081
fix(tooltip): resolve test timeout
5t3ph 2460440
fix(tooltip): fix 1st-gen warning test for self-managed
5t3ph a9bb9e7
Merge branch 'seckles/tooltip-code-styles-tests' of https://github.co…
5t3ph c121f1d
fix(tooltip): remove reference to console.log
5t3ph c6bbb27
feat(tooltip): support `labeling` attribute
5t3ph 92cdaa9
feat(tooltip): update migration plan for `labeling`
5t3ph 81e099d
fix(tooltip): update Button type cast
5t3ph 4d28886
feat(tooltip): harden `transitionDuration` check
5t3ph 3dc9c3f
fix(tooltip): add aria-label due to axe-core limitation
5t3ph 9f73308
Merge branch 'seckles/tooltip-code-styles-tests' of https://github.co…
5t3ph ba73d86
feat(tooltip): add `labeling` into a11y story
5t3ph cb82664
Merge branch 'swc-2017/tooltip' of https://github.com/adobe/spectrum-…
5t3ph File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice, but I feel like our whole SB customization needs some love 😛 cc: @caseyisonit