chore(swc): upgrade Storybook to 10.4.1 and Vitest to 4.1.7#6343
Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
| } | ||
|
|
||
| .swc-Button { | ||
| }.swc-Button { |
There was a problem hiding this comment.
i dont understand why the formatting is changing it so the end bracket is starting the new line. Im not sure why this would be getting picked up in a version bump PR? is there a side effect to this?
There was a problem hiding this comment.
AAAARRRR i've been getting this file change locally every time and I accidentally committed it. i need to investigate this! - I'll remove it for now
| statements: 98, | ||
| lines: 100, | ||
| functions: 100, | ||
| statements: 100, |
There was a problem hiding this comment.
do we want to bump to 100? im fine with it but we might need to check this against whats in the system currently?
There was a problem hiding this comment.
ooops this also got accidentally committed. we currently have a setting that rewrites this baseline to the current value whenever we run the coverage checks. I'll revert it because it's out of scope of this PR
| files: '**/*.test.ts', | ||
| }); | ||
| stories.push({ | ||
| ...CORE_STORY_ROOT, |
e912d79 to
4aaac4b
Compare
Description
Upgrades Storybook and Vitest to their latest versions, and fixes two issues in the Storybook dev server: the coverage report link returning 404, and a startup warning about an unmatched story glob.
Package versions bumped
storybook@storybook/addon-a11y@storybook/addon-docs@storybook/addon-vitest@storybook/web-components-vite@storybook/test-runner@chromatic-com/storybook@wc-toolkit/storybook-helpersvitest@vitest/browser@vitest/browser-playwright@vitest/coverage-v8@vitest/uiYarn patches ported
Two existing patches were carried forward to the new package versions (neither bug is fixed upstream):
storybookautoplay patch: Prevents play functions from running on initial story load whenparameters.autoplayis not explicitlytrue. Without this, stories auto-run their play function on first render, which can interfere with how docs and overview stories appear.@wc-toolkit/storybook-helperscssProperties patch: Suppresses a block that adds all CSS custom properties to the Storybook controls table withtable: { disable: true }, which caused redundant hidden entries to appear in the controls panel.Coverage report now accessible in the dev server
Clicking the coverage link in Storybook's Vitest panel previously opened
http://localhost:6006/coverage/index.htmland returned Not Found. Thecoverage/directory is now mapped as a static dir in.storybook/main.ts, but only when the directory already exists (guarded withexistsSync) so starting Storybook before running coverage does not produce an error.To use: run
yarn test:coveragefirst, then start Storybook. The coverage link will resolve correctly.Startup warning removed
Removed a story glob pattern (
../core/**/stories/**/*.test.ts) that matched no files, which produced a▲ No story files foundwarning on every dev server start. It's being fixed here: #6341Motivation and context
Routine dependency maintenance to stay current with Storybook and Vitest releases, plus fixes for two developer experience issues surfaced during local development.
Related issue(s)
N/A
Author's checklist
Accessibility testing checklist
This is a dependency upgrade with no changes to component behavior, markup, or ARIA implementation. No accessibility testing is required.