feat(action-button): S2 migration#6340
Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
589d0c6 to
4f6ac56
Compare
…ponent (#6327) * feat(action-button): adds migration plan for the S2 action button component * chore(action-button): address feedback * chore(action-button): address feedback
* chore(action-button): adds structure for s2 migration * chore: clean up base class and export types * chore(action-button): update migration plan * chore(action-button): address feedback
4f6ac56 to
578f5dd
Compare
Description
Umbrella PR for the
swc-action-button1st-gen → 2nd-gen Spectrum 2 migration. All phase PRs target this branch and are merged here before this PR lands onmain.Migration plan:
CONTRIBUTOR-DOCS/03_project-planning/03_components/action-button/migration-plan.md(merged in #6327)Phase PRs
Motivation and context
swc-action-buttonis part of the Spectrum 2 component migration workstream. Key changes from 1st-gen:<button>as the semantic control (host no longer carriesrole="button")toggles,selected,emphasized— toggle UX moves toswc-toggle-button/swc-toggle-button-grouphold-affordance/longpresshrefand related attributes)accessible-labelreplaceslabel;aria-haspopup/aria-expandedare forwarded to the inner<button>for menu-trigger patternspendingstate (new in 2nd-gen, matchingswc-button)--swc-action-button-*custom properties instead of the 1st-gen--mod-*/--spectrum-actionbutton-*chainRelated issue(s)
SWC-2039
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
To be populated in Phase 6 (testing). See the migration plan for the full verification matrix.
Device review
Accessibility testing checklist
To be populated in Phase 6 (testing). See the migration plan accessibility verification section for the full checklist.