feat(accordion): migrate to 2nd-gen#6268
Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
e64ac01 to
66d4919
Compare
66d4919 to
424db20
Compare
432f56c to
057a70a
Compare
f741213 to
4b0e1eb
Compare
Co-authored-by: Nikki Massaro <massaro@adobe.com>
* chore: scaffold core package * chore: scaffold swc package * chore: add Chevron300Icon for xl accordion * chore: set up storybook story * chore: commit preview.ts updates * feat: implement AccordionItem API and render template * feat: implement Accordion API and propagation * feat: implement open and toggle logic * feat: wire up dynamic heading levels * feat: implement disabled item functionality * fix: handle space keyboard behavior (SWC-1487) * refactor: address missing migration-setup items * refactor: rename methods, align file names * refactor: typing, heading rendering, sizing * refactor: move toggle() into base, smooth a11y behavior * refactor: use assignedItems() helper * test: add a11y tests * docs: add a11y docs * fix: freeze accordion open state when disabled * feat: 1st-gen deprecation warnings/tests * docs: jsdoc comments * chore: changeset * fix: revert 1st-gen refactor work * chore(accordion): defer tests, deprecations, and changeset to part two Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: class selectors * refactor: use ObserveSlotPresence instead of bespoke method * refactor: remove stop propagation on actions container * refactor: add open/close events --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* docs(accordion): refine planning docs (#6269) Co-authored-by: Nikki Massaro <massaro@adobe.com> * chore: scaffold core package * chore: scaffold swc package * chore: add Chevron300Icon for xl accordion * chore: set up storybook story * chore: commit preview.ts updates * feat: implement AccordionItem API and render template * feat: implement Accordion API and propagation * feat: implement open and toggle logic * feat: wire up dynamic heading levels * feat: implement disabled item functionality * fix: handle space keyboard behavior (SWC-1487) * refactor: address missing migration-setup items * refactor: rename methods, align file names * refactor: typing, heading rendering, sizing * refactor: move toggle() into base, smooth a11y behavior * refactor: use assignedItems() helper * test: add a11y tests * docs: add a11y docs * fix: freeze accordion open state when disabled * feat: 1st-gen deprecation warnings/tests * docs: jsdoc comments * chore(accordion): full fidelity feature update * chore: changeset * fix: revert 1st-gen refactor work * chore(accordion): defer tests, deprecations, and changeset to part two Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs(accordion): refine planning docs (#6269) Co-authored-by: Nikki Massaro <massaro@adobe.com> * chore: scaffold core package * chore: scaffold swc package * chore: add Chevron300Icon for xl accordion * chore: set up storybook story * chore: commit preview.ts updates * feat: implement AccordionItem API and render template * feat: implement Accordion API and propagation * feat: implement open and toggle logic * feat: wire up dynamic heading levels * feat: implement disabled item functionality * fix: handle space keyboard behavior (SWC-1487) * refactor: address missing migration-setup items * refactor: rename methods, align file names * refactor: typing, heading rendering, sizing * refactor: move toggle() into base, smooth a11y behavior * refactor: use assignedItems() helper * test: add a11y tests * docs: add a11y docs * fix: freeze accordion open state when disabled * feat: 1st-gen deprecation warnings/tests * docs: jsdoc comments * chore: changeset * fix: revert 1st-gen refactor work * chore(accordion): defer tests, deprecations, and changeset to part two Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(accordion): update css font * fix: class selectors * feat: set up accordion file structure, API, and a11y (#6300) * chore: scaffold core package * chore: scaffold swc package * chore: add Chevron300Icon for xl accordion * chore: set up storybook story * chore: commit preview.ts updates * feat: implement AccordionItem API and render template * feat: implement Accordion API and propagation * feat: implement open and toggle logic * feat: wire up dynamic heading levels * feat: implement disabled item functionality * fix: handle space keyboard behavior (SWC-1487) * refactor: address missing migration-setup items * refactor: rename methods, align file names * refactor: typing, heading rendering, sizing * refactor: move toggle() into base, smooth a11y behavior * refactor: use assignedItems() helper * test: add a11y tests * docs: add a11y docs * fix: freeze accordion open state when disabled * feat: 1st-gen deprecation warnings/tests * docs: jsdoc comments * chore: changeset * fix: revert 1st-gen refactor work * chore(accordion): defer tests, deprecations, and changeset to part two Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: class selectors * refactor: use ObserveSlotPresence instead of bespoke method * refactor: remove stop propagation on actions container * refactor: add open/close events --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(accordion): address PR review feedback on CSS and stories Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(accordion): restore row wrapper and register swc-button in stories * fix(accordion): change ceiling amount to spacing-300 * fix(accordion): fix token names for header and content sections * fix: move private custom properties from accordion-item :host * fix: adjust .swc-AccordionItem-header custom properties * fix: adjust content inline padding custom properties * chore: update preview.ts and migration plan * feat: spacing on direct actions * docs: improve ai skill * fix: use <p>s in stories and account for their margin * docs: add cssprops to jsdocs * chore: rename custom props for accordion item * feat: handle panel animation * fix: use better selectors * docs: docs updates * fix: handle quiet and corner radius tokens * chore: update migration plan * fix: feedback fixes --------- Co-authored-by: rise-erpelding <54716846+rise-erpelding@users.noreply.github.com> Co-authored-by: Nikki Massaro <massaro@adobe.com> Co-authored-by: Rise Erpelding <rise@heysparkbox.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
b6d8ccb to
66c126e
Compare
Description
Feature branch for migration of the Accordion component to 2nd-gen
Motivation and context
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Items to address
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Descriptive Test Statement
Descriptive Test Statement
Device review
Accessibility testing checklist
Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).
Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.
Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.