fix: markdown rendering for custom types

[sharanyavinod]

• Handles rendering of all custom types defined here - https://github.com/adobe-rnd/da-agent/blob/main/docs/agent-markdown-outputs.md - except for ones related to skills
• Note: no final mocks yet, so basic styling done using spectrum for inspiration

Preview at https://da.live/canvas?nx=ew-md&nxver=2#/exp-workspace/frescopa/index

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

• Re-sync branch

Commits

• 8f4003d ✅ (latest)
• c433b01 ✅
• 74bb4c2 ✅
• 33e983a ✅
• 90b6db8 ✅
• d8e88bc ✅
• 9b9c553 ✅

[anfibiacreativa]

mask-image: url("/nx2/img/icons/S2_Icon_Checkmark_20_N.svg") is a hardcoded absolute asset path. breaks if the asset structure ever moves. we have flagged this before (see other icon usage with loadHrefSvg). @hannessolo what was the decision here?

[hannessolo]

Yes, we should use <svg><use> wherever possible. The icons shouldn't be added to the code, but referenced directly from da.live, eg. https://da.live/img/icons/s2-icon-checkmark-20-n.svg

[sharanyavinod]

This is pure styling, so didnt want to add an svg. I'll update to have the live url then - I saw a couple other similar usages, will adapt those in parallel as well.

[hannessolo]

Yes, that's why "wherever possible" - I think here your approach might make more sense. But I'm not sure, will dark mode work with mask-image?
In either case we should use the URL from da.live instead of adding the svg to the code.

[sharanyavinod]

Yes, currentcolor on the background will inherit the parent color. I'll adapt to use the url -> for the others I think we might need to first add the icons to da live

[anfibiacreativa]

we're using var(--s2-spacing-75) right next to these. do spacing tokens cover 4px and 6px? if so, let's use them too.

[hannessolo]

Nice, looks much better!

I'm fine with the current implementation for now, but as an improvement we should find a way to already render the correct style before the closing tag appears.