Skip to content

CEXT-6138: SDK Capability Discovery - #427

Closed
iivvaannxx wants to merge 12 commits into
mainfrom
poc/openapi-generation-router
Closed

CEXT-6138: SDK Capability Discovery#427
iivvaannxx wants to merge 12 commits into
mainfrom
poc/openapi-generation-router

Conversation

@iivvaannxx

Copy link
Copy Markdown
Collaborator

No description provided.

@changeset-bot

changeset-bot Bot commented May 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4d648e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adobe/aio-commerce-lib-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added without-changeset The PR does not contain a Changeset file pkg: aio-commerce-lib-core Includes changes in `packages/aio-commerce-lib-core` pkg: aio-commerce-lib-app Includes changes in `packages/aio-commerce-lib-app` private-pkg: common-utils Includes changes in `packages-private/common-utils` labels May 6, 2026
@iivvaannxx
iivvaannxx marked this pull request as draft May 6, 2026 12:51
@github-actions github-actions Bot removed the pkg: aio-commerce-lib-core Includes changes in `packages/aio-commerce-lib-core` label May 6, 2026
@iivvaannxx
iivvaannxx marked this pull request as ready for review May 13, 2026 14:05
@iivvaannxx iivvaannxx changed the title PoC: OpenAPI CEXT-6138: SDK Capability Discovery May 13, 2026

@obarcelonap obarcelonap left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to flag the spec CEXT-6138 as implemented.
Also, we need to document from user perspective that filtered openapi spec is available as new endpoint, usage.md in aio-commerce-lib-app?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the final content? I am missing all the endpoints
additionally, I guess we will need to filter the content in pre-app-build hook

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content filtering is pending yeah, thought it wasn't necessary but it is, will add. The final content I'll push just before merge, it only adds noise to diff count of PR and I didn't want to scare people with a 6K lines PR

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up doing so in the app-config at runtime to avoid tampering and because I think it's a bit simpler than having to script the generation of an extra file, let me know what you think.

@jcuerdo jcuerdo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset is missing too.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test for this file. Check others

@iivvaannxx
iivvaannxx force-pushed the poc/openapi-generation-router branch from 1bedecb to 669eda0 Compare May 28, 2026 09:05
@iivvaannxx
iivvaannxx force-pushed the poc/openapi-generation-router branch from ac7ee55 to 4d648e7 Compare May 29, 2026 12:37
@github-actions github-actions Bot added with-changeset The PR contains a Changeset file. and removed without-changeset The PR does not contain a Changeset file labels May 29, 2026
@iivvaannxx

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #481

@iivvaannxx iivvaannxx closed this May 29, 2026
@iivvaannxx
iivvaannxx deleted the poc/openapi-generation-router branch May 29, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: aio-commerce-lib-app Includes changes in `packages/aio-commerce-lib-app` private-pkg: common-utils Includes changes in `packages-private/common-utils` with-changeset The PR contains a Changeset file.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants