Skip to content

Disable smem spilling for relocatable device code#1356

Merged
stephenswat merged 1 commit into
acts-project:mainfrom
stephenswat:fix/spill_rdc
Jun 24, 2026
Merged

Disable smem spilling for relocatable device code#1356
stephenswat merged 1 commit into
acts-project:mainfrom
stephenswat:fix/spill_rdc

Conversation

@stephenswat

Copy link
Copy Markdown
Member

The shared memory register spilling pragma doesn't worm in relocatable CUDA device code for obvious reasons. This commit updates the compiler macro we use to invoke this PTX pragma so that it doesn't run when the CUDA compiler is set to emit relocatable code, or when it is running in debug mode (which also enabled RDC).

The shared memory register spilling pragma doesn't worm in relocatable
CUDA device code for obvious reasons. This commit updates the compiler
macro we use to invoke this PTX pragma so that it doesn't run when the
CUDA compiler is set to emit relocatable code, or when it is running in
debug mode (which also enabled RDC).
@stephenswat stephenswat added bug Something isn't working cuda Changes related to CUDA labels Jun 24, 2026

@krasznaa krasznaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks correct. 🤞

@stephenswat stephenswat merged commit 2779cf6 into acts-project:main Jun 24, 2026
26 of 27 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cuda Changes related to CUDA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants