Disable smem spilling for relocatable device code#1356
Merged
Conversation
The shared memory register spilling pragma doesn't worm in relocatable CUDA device code for obvious reasons. This commit updates the compiler macro we use to invoke this PTX pragma so that it doesn't run when the CUDA compiler is set to emit relocatable code, or when it is running in debug mode (which also enabled RDC).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The shared memory register spilling pragma doesn't worm in relocatable CUDA device code for obvious reasons. This commit updates the compiler macro we use to invoke this PTX pragma so that it doesn't run when the CUDA compiler is set to emit relocatable code, or when it is running in debug mode (which also enabled RDC).